Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anisotropy tests to render-fidelity-tests (and update Babylon + Filament to latest) #4535

Merged
merged 31 commits into from
Nov 8, 2023
Merged

Add anisotropy tests to render-fidelity-tests (and update Babylon + Filament to latest) #4535

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
70862b6
init submodule for glTF-Sample-Assets.
bhouston Oct 24, 2023
37f5faa
fix left over popd in fetch khronos gltf-smaples.
bhouston Oct 24, 2023
e8ead7e
remove tests from config.json that no longer have corresponding asset…
bhouston Oct 24, 2023
fb17048
upgrade babylon + filament, check in their latest goldens for new ani…
bhouston Oct 24, 2023
7390b25
update config.json with the new anisotropy tests.
bhouston Oct 24, 2023
17e936e
add more time for tests.
bhouston Oct 25, 2023
33d17e2
add more gltf tests along with goldens for filament,babylon and model…
bhouston Oct 25, 2023
b89fa9a
using checkout with submodule support.
bhouston Oct 25, 2023
bc5c08f
Merge branch 'additional-tests' of [email protected]:bhouston/model-view…
bhouston Oct 25, 2023
9647901
using checkout with submodule support.
bhouston Oct 25, 2023
a11d8cf
update goldens for model-viewer + filament for khronos-TextureTransfo…
bhouston Oct 25, 2023
c850c59
update goldens for model-viewer + filament for khronos-TextureTransfo…
bhouston Oct 25, 2023
ed9844e
add more goldens for anisotropy from gltf-sample-viewer and three-gpu…
bhouston Oct 25, 2023
bce8a03
add more goldens for anisotropy from gltf-sample-viewer and three-gpu…
bhouston Oct 25, 2023
2ed0708
exclude a few renderers for now to get the PR accepted.
bhouston Oct 25, 2023
e8e0be2
exclude a few renderers for now to get the PR accepted.
bhouston Oct 25, 2023
66ba502
add gltf-sample viewer goldens for new tests.
bhouston Oct 25, 2023
47167db
add goldens for AnisotropyDiscTest
bhouston Oct 25, 2023
342a9e2
remove barn lamp test for now.
bhouston Oct 25, 2023
a8ffc1d
remove blank golden image.
bhouston Oct 26, 2023
26468e2
remove barn lamp test for now.
bhouston Oct 25, 2023
b04a230
exclude three-gpu-pathtracer from rotation test.
bhouston Oct 26, 2023
41b8d8d
exclude three-gpu-pathtracer from rotation test.
bhouston Oct 26, 2023
89add3e
Merge remote-tracking branch 'origin/master' into additional-tests
bhouston Oct 26, 2023
d6a589b
Merge remote-tracking branch 'origin/master' into additional-tests
bhouston Oct 27, 2023
648c5fc
remove failing test for now.
bhouston Oct 27, 2023
7cd01be
Merge branch 'even-more-tests' into additional-tests
bhouston Oct 27, 2023
6a66cdd
Merge branch 'master' into additional-tests
bhouston Oct 30, 2023
5ee586a
add missing anisotropy goldens, and re-add barn lamp with model-viewe…
bhouston Oct 30, 2023
c684bb8
ensure goldens tests are excluded if renderer is excluded.
bhouston Oct 30, 2023
028c52f
remove blank image.
bhouston Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/fidelity-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ on: pull_request
jobs:
compare_renders:
runs-on: ubuntu-latest
timeout-minutes: 60
timeout-minutes: 90

steps:
- uses: actions/checkout@v3
with:
submodules: true

- uses: actions/setup-node@v3
with:
node-version: '16.x'
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "packages/shared-assets/models/glTF-Sample-Assets"]
path = packages/shared-assets/models/glTF-Sample-Assets
url = [email protected]:KhronosGroup/glTF-Sample-Assets
52 changes: 26 additions & 26 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/render-fidelity-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
},
"dependencies": {
"@actions/core": "^1.2.4",
"@babylonjs/core": "^5.44.0",
"@babylonjs/loaders": "^5.44.0",
"@babylonjs/core": "^6.25.0",
"@babylonjs/loaders": "^6.25.0",
"@google/model-viewer": "^3.3.0",
"@khronosgroup/gltf-viewer": "^1.0.9",
"@polymer/paper-button": "^3.0.1",
Expand All @@ -36,7 +36,7 @@
"@types/puppeteer": "^5.4.6",
"@types/rimraf": "^3.0.1",
"@types/three": "^0.156.0",
"filament": "1.31.5",
"filament": "1.44.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did none of the existing renders change appreciably when these versions were bumped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you merge in the other PR, I can run the fidelity test with "filament" as the target renderer and find out!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, lots of PRs merged - let's see how this does when it's all pulled together!

"http-server": "^14.1.1",
"lit": "^2.7.2",
"mkdirp": "^1.0.4",
Expand Down
Loading