[BC] Refactor _KEEP_TEMPS for reusability
#376
Merged
+54
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given by combine_tfa_policies_lib.get_input_signature() and action spec given by combine_tfa_policies_lib.get_action_spec() The combiner policy uses a new timestep spec feature "model_selector" to select the requested policy at the current state. The feature is computed as a md5 hash from the respective policies names.
…iler-opt into policy_combiner
TimeStep. The patch also gives the option to keep the temporary working_dir by setting keep_temps in compilation_runner.py to a directory where all temporary working_dirs will be saved.
mtrofin
approved these changes
Oct 1, 2024
| @@ -80,6 +80,18 @@ def __exit__(self, exc, value, tb): | |||
| pass | |||
|
|
|||
|
|
|||
| def get_directory_context(): | |||
There was a problem hiding this comment.
I'd rename this to be more specific, how about get_workdir_context (otherwise... lots of directories, so which one is this :) )
compiler_opt/rl/env_test.py
Outdated
| self.assertEqual(os.path.exists(working_dir), False) | ||
|
|
||
| with flagsaver.flagsaver( | ||
| (env.compilation_runner._KEEP_TEMPS, '/tmp')): # pylint: disable=protected-access |
There was a problem hiding this comment.
can you use instead of /tmp self.create_tempdir()?
There was a problem hiding this comment.
Can you check if this looks good now?
|
Can you rename also the title of the change to e.g. "factor _KEEP_TEMP for reusability" or something in that vein |
boomanaiden154
approved these changes
Oct 1, 2024
| """Return a context which manages how the temperory directories are handled. | ||
|
|
||
| When the flag keep_temps is specified temporary directories are stored in | ||
| keep_temps.""" |
There was a problem hiding this comment.
Nit: The """ string terminator should be on a separate line.
mtrofin
changed the title
_KEEP_TEMPS for reusability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch that adds the option to keep temporary working_dir in env.py and adds working_dir as part of TimeStep in env.py