Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads conversions consent support #155

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Ads conversions consent support #155

merged 7 commits into from
Dec 12, 2023

Conversation

jsraucci
Copy link
Collaborator

@jsraucci jsraucci commented Dec 7, 2023

Adding support to send consent data in Google Ads Conversions:
Click, EC4L, CallConversions
Also includes external attribution for EC4L

Copy link
Collaborator

@Mr-Lopes Mr-Lopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for this!

@jsraucci jsraucci merged commit 073c4b8 into main Dec 12, 2023
5 checks passed
Mr-Lopes pushed a commit that referenced this pull request Dec 13, 2023
* adding consent on payload for OCI, EC4L and Call Conversions

* adding consent ondata schemas and removingexternal atribution from call conversions

* adding unit tests for sending oci with consent

* fixing conversion call uploader

* fixing payload

* fixing calls uploader

---------

Co-authored-by: Julia Raucci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants