-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5 #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, Pedro!
I added a few comments.
Thanks!
@@ -1,13 +1,12 @@ | |||
apache-beam==2.51.0 | |||
google-ads-megalista | |||
google-ads==22.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump the google-ads-megalista instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're able to use the official version, I think we reduce the overhead of keeping and supporting another component.
'transaction_upload_fraction': 1.0 | ||
} | ||
"type_": "STORE_SALES_UPLOAD_FIRST_PARTY", | ||
"external_id": int(datetime.datetime.now().timestamp() * 10e3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Pedro,
Is the external_id param used now? I remember that this was a parameter that was added but never used.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's still optional, but the documentation recommends it.
_ads_mcc_account_id = '0987654321' | ||
_ads_account_override = '12121212121' | ||
_ga_account_id = '3456789' | ||
_ads_account_id = "1234567890" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these actual accounts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are fake ones
This PR adds the following features: