V5 #151
Merged
V5 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Lopes
requested review from
guadix,
cymbaum,
charlie6,
jsraucci and
anaesqueda
anaesqueda
approved these changes
Nov 8, 2023
| @@ -1,13 +1,12 @@ | |||
| apache-beam==2.51.0 | |||
| google-ads-megalista | |||
| google-ads==22.1.0 | |||
There was a problem hiding this comment.
Should we bump the google-ads-megalista instead?
There was a problem hiding this comment.
Since we're able to use the official version, I think we reduce the overhead of keeping and supporting another component.
| 'transaction_upload_fraction': 1.0 | ||
| } | ||
| "type_": "STORE_SALES_UPLOAD_FIRST_PARTY", | ||
| "external_id": int(datetime.datetime.now().timestamp() * 10e3), |
There was a problem hiding this comment.
Hi Pedro,
Is the external_id param used now? I remember that this was a parameter that was added but never used.
Thanks!
There was a problem hiding this comment.
it's still optional, but the documentation recommends it.
| _ads_mcc_account_id = '0987654321' | ||
| _ads_account_override = '12121212121' | ||
| _ga_account_id = '3456789' | ||
| _ads_account_id = "1234567890" |
There was a problem hiding this comment.
Are these actual accounts?
There was a problem hiding this comment.
Those are fake ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following features: