Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling pinch with any number of fingers #390

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mehdi-cit
Copy link

Hello,
By default, marzipano doesn't allow for multi finger dragging/rotating as seen here:
#367
In my use case. I need to allow the user to drag/rotate the picture when using one, two or more fingers. I.e. no matter how many fingers the user is able to do the same thing.
As of version "marzipano": "0.10.2", one can use two fingers when passing some "pinch" option! However, this has two limitations when it comes to my use case. First, it won't work when using more than two fingers. Second, if using a single finger it has no effect on the image and the scrolling happens (or is supposed to happen) on the containing page/widget.
This is a PR for allowing such thing.

@google-cla
Copy link

google-cla bot commented Apr 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mehdi-cit
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Apr 14, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mehdi-cit
Copy link
Author

@googlebot I fixed it.

@hemanthere
Copy link

This is a great addition, fits perfectly into our use-case where we want users to interact with our product on big screens in our stores. Would be great to see PR being approved.

@mehdi-cit
Copy link
Author

Please, let us know if this PR is not going to be considered and why!
Maybe I should create a fork (we really need multi-touch)

@HemantKumarSharma2
Copy link

@tjgq Can you please approve and merge this Pull request, if everything is fine with the PR? I would really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants