KSP2: support KMP w. the current processing model #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ting-yuan
force-pushed
the
kmp2
branch
4 times, most recently
from
77b3acf to
9baf611
Compare
neetopia
reviewed
Dec 6, 2023
| cfg.libraries.from(target.listFiles()) | ||
| } | ||
|
|
||
| // TODO: pass targets of common |
There was a problem hiding this comment.
I did not see JS here, is there any need for JS?
There was a problem hiding this comment.
The only extra config of js over the shared is backend, which is determined later by platform type. Therefore, nothing is needed here.
gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspSubplugin.kt
Show resolved
Hide resolved
instead of project.konanHome, which is internal.
neetopia
approved these changes
Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.