Handle unknown json::value_t kinds (by aborting) #1141
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with bundled JSON and bundled RapidYAML, the build works. However, when building with system-provided JSON and bundled RapidYAML, the build fails due to many things not being defined. It seems these are supposed to come from the standard <charconv> header, but RapidYAML 0.5.0 release erroneously strips that include in its single-file amalgamation. See RapidYAML issue biojppm/rapidyaml#364 (comment)
This should prevent a compile warning when building against nlohmann json.hpp v3.8.0 or greater, which add an extra value_t kind for binary data.
johnbartholomew
force-pushed
the
default-case-json-value
branch
from
9fdc337 to
5cd4c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent a compile warning when building against nlohmann json.hpp v3.8.0 or greater, which add an extra value_t kind for binary data, without requiring a newer version to build.
Fixes #1031.
Ref #926 which was a previous attempt to fix this compiler warning, and #1023 which reverted that previous attempt.