Create build-and-test GitHub workflow #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running clang-format in a mode that generates XML and then grepping and counting that output and using the shell 'test' command on _that_ output to work out whether the formatter recommended changes, use clang-format --dry-run -Werror so that the formatter will exit with a failure code if it finds anything it wants to reformat, and not otherwise do anything. This just makes the 'test-formatting' make target a little simpler.
There are three jobs in the workflow (jobs run independently) - Build and Test using the plain Makefile and ./tests.sh script. - Build and Test using CMake & CTest. - Check code formatting using clang-format. The last (check formatting) is disabled because right now the code doesn't conform to clang-format's desired output. Once the code has been reformatted, the workflow job can be enabled so that future PRs can be automatically checked for format regressions.
johnbartholomew
force-pushed
the
ci-test-prs
branch
from
6863a2c to
cb633a5
Compare
johnbartholomew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I don't have a great way to check github workflow configuration syntax locally so I may need to churn through many commits for this PR
Post-merge edit: Please check the actual commit messages for details of what was done here.