Refactor Preview UI #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasith
reviewed
Aug 23, 2023
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Show resolved
Hide resolved
...preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/PreviewScreenComponents.kt
Outdated
Show resolved
Hide resolved
...preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/PreviewScreenComponents.kt
Outdated
Show resolved
Hide resolved
...preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/PreviewScreenComponents.kt
Outdated
Show resolved
Hide resolved
...preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/PreviewScreenComponents.kt
Show resolved
Hide resolved
...settings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsScreen.kt
Outdated
Show resolved
Hide resolved
Kimblebee
force-pushed
the
kim/refactor_preview
branch
from
2956842
to
29047c0
Compare
Kimblebee
force-pushed
the
kim/refactor_preview
branch
from
29047c0
to
5549b0f
Compare
yasith
requested changes
Sep 8, 2023
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
...preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/PreviewScreenComponents.kt
Outdated
Show resolved
Hide resolved
...preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/PreviewScreenComponents.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/google/jetpackcamera/feature/quicksettings/ui/QuickSettingsComponents.kt
Outdated
Show resolved
Hide resolved
...settings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsScreen.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Show resolved
Hide resolved
feature/settings/src/main/java/com/google/jetpackcamera/settings/ui/SettingsComponents.kt
Outdated
Show resolved
Hide resolved
feature/settings/src/main/java/com/google/jetpackcamera/settings/ui/SettingsComponents.kt
Outdated
Show resolved
Hide resolved
feature/settings/src/main/java/com/google/jetpackcamera/settings/ui/SettingsComponents.kt
Show resolved
Hide resolved
Kimblebee
force-pushed
the
kim/refactor_preview
branch
from
43a22f1
to
8cf9ea1
Compare
Kimblebee
force-pushed
the
kim/refactor_preview
branch
from
8cf9ea1
to
51fe392
Compare
yasith
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored UI for better appearance, readability, and maintainability; There is no change in functionality and minimal change in appearance.
Here's a brief summary of the changes in this PR:
Compartmentalized the logic that already exists within the
/preview/PreviewScreen.kt, and moved most of it into/preview/ui/PreviewScreenComponents.kt. Big adjustments on use of containers and modifiers.Adjusted some modifiers for
QuickSettingsScreen.kt;I added a "flip camera" button to the preview screen for easier access
I also added minor styling changes to the Settings screen; added colors and adjusted some spacing.