implement tap to focus #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimblebee
force-pushed
the
kim/tap_to_focus
branch
from
d582003
to
4453d4b
Compare
yasith
approved these changes
Aug 9, 2023
domain/camera/src/main/java/com/google/jetpackcamera/domain/camera/CameraXCameraUseCase.kt
Show resolved
Hide resolved
camera-viewfinder-compose/src/main/java/com/google/jetpackcamera/viewfinder/surface/Texture.kt
Outdated
Show resolved
Hide resolved
domain/camera/src/main/java/com/google/jetpackcamera/domain/camera/CameraXCameraUseCase.kt
Show resolved
Hide resolved
Kimblebee
force-pushed
the
kim/tap_to_focus
branch
from
4453d4b
to
e202f63
Compare
Kimblebee
force-pushed
the
kim/tap_to_focus
branch
from
e202f63
to
c966e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
PreviewScreen, I created a value that keeps track of the View information from the CameraPreview composable. I just pass down a callback function from CameraPreview -> PreviewSurface -> CombinedSurface -> Texture to set that value.When the screen is tapped, then the display, height, and width information of the view is provided to
PreviewViewModel's tapToFocus(), which is then provides that info tocameraUseCase.tapToFocusto create a metering point and action to focus.