Save Camera Properties to external file when in debug mode #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidjiagoogle
commented
Aug 29, 2024
davidjiagoogle
commented
- When in debug mode, compile the needed camera properties for all cameras and write into a text file in JSON format
- Included a fix in setOnCaptureCompleteCallback() where the debugInfo in currentCameraState is being constantly updated for each preview frame even if the camera didn't change
temcguir
reviewed
Sep 3, 2024
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
Jaehwa-Noh
reviewed
Sep 4, 2024
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
temcguir
reviewed
Sep 6, 2024
core/camera/src/main/java/com/google/jetpackcamera/core/camera/DebugCameraInfoUtil.kt
Outdated
Show resolved
Hide resolved
Jaehwa-Noh
reviewed
Sep 10, 2024
core/common/src/main/java/com/google/jetpackcamera/core/common/CommonModule.kt
Outdated
Show resolved
Hide resolved
core/common/src/main/java/com/google/jetpackcamera/core/common/CommonModule.kt
Outdated
Show resolved
Hide resolved
temcguir
reviewed
Sep 10, 2024
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/DebugCameraInfoUtil.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/DebugCameraInfoUtil.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/DebugCameraInfoUtil.kt
Outdated
Show resolved
Hide resolved
core/camera/src/main/java/com/google/jetpackcamera/core/camera/DebugCameraInfoUtil.kt
Outdated
Show resolved
Hide resolved
temcguir
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.