[WIP] temcguir/hdr quick setting with single stream #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Viewfinder is showing HDR content, we want to change the window ColorMode to COLOR_MODE_HDR. This will propagate the color mode from CameraXViewfinder when the source has HDR content and the ImplementationMode is PERFORMANCE. (SurfaceView is only view that can show HDR content)
Most devices can't support SDR + HDR streams concurrently. Disable ImageCapture if the DynamicRange is HDR.
Whenever the camera is switched, the constraints of supported dynamic range need to be updated.
This is used for shared state between threads.
Hacks in a GLES3 shader to allow for copying 10-bit pixels.
This effects processor uses the graphics-core library's GLRenderer to perform rendering rather than CameraX's internal OpenGLRenderer. This renderer can handle SDR and 10-bit HLG dynamic ranges.
Factors out the shader copying code into its own class, ShaderCopy. This will allow us to create separate implementations to perform the copy that do not just use shaders.
This has a lifecycle controlled by a coroutineScope, so it needs to get that scope from the calling coroutineScope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.