QuickSettings back press addressing comments #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjiagoogle
changed the title
temcguir
reviewed
Mar 4, 2024
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/TestTags.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/TestTags.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/TestTags.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/google/jetpackcamera/NavigationTest.kt
Outdated
Show resolved
Hide resolved
…gle/jetpack-camera-app into david/quickSettingBackButton
…gle/jetpack-camera-app into david/quickSettingBackButton
temcguir
reviewed
Mar 5, 2024
...settings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsScreen.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/google/jetpackcamera/feature/quicksettings/ui/QuickSettingsComponents.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/google/jetpackcamera/feature/quicksettings/ui/QuickSettingsComponents.kt
Outdated
Show resolved
Hide resolved
temcguir
reviewed
Mar 9, 2024
…gle/jetpack-camera-app into david/quickSettingBackButton
…gle/jetpack-camera-app into david/quickSettingBackButton
…gle/jetpack-camera-app into david/quickSettingBackButton
…gle/jetpack-camera-app into david/quickSettingBackButton
temcguir
reviewed
Mar 12, 2024
app/src/androidTest/java/com/google/jetpackcamera/NavigationTest.kt
Outdated
Show resolved
Hide resolved
temcguir
approved these changes
Mar 12, 2024
…gle/jetpack-camera-app into david/quickSettingBackButton
…gle/jetpack-camera-app into david/quickSettingBackButton
davidjiagoogle
added a commit
that referenced
this pull request
Mar 14, 2024
* Fix quick settings back press * Update TestTags.kt * Fix quick settings back press * Update NavigationTest.kt
davidjiagoogle
added a commit
that referenced
this pull request
Mar 22, 2024
* QuickSettings back press addressing comments (#130) * Fix quick settings back press * Update TestTags.kt * Fix quick settings back press * Update NavigationTest.kt * Image Capture UI Indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comments from preview PR