QuickSettings Foundation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
…ra-app into david/quicksettings
jsaund
reviewed
Jun 23, 2023
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
jsaund
reviewed
Jun 23, 2023
jsaund
reviewed
Jun 23, 2023
...ings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsComponents.kt
Outdated
Show resolved
Hide resolved
jsaund
reviewed
Jun 23, 2023
...ings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsComponents.kt
Outdated
Show resolved
Hide resolved
…ra-app into david/quicksettings
jsaund
reviewed
Jun 27, 2023
...ettings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsUiModel.kt
Show resolved
Hide resolved
...ksettings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsEnums.kt
Outdated
Show resolved
Hide resolved
yasith
approved these changes
Jun 27, 2023
...ings/src/main/java/com/google/jetpackcamera/feature/quicksettings/QuickSettingsComponents.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is effective an extended branch of the feature.preview module. In terms of dependency, it depends on no other modules and is depended by feature.preview.
QuickSettingsUi is the drop down arrow. It has a composable below that spans the whole screen. When retracted, this composable is empty. When expanded, this composable is populated by ExpandedQuickSettingsUi.
ExpandedQuickSettingsUi is the composable with quickSetting items inside. It can be further expanded when one of its items is clicked.
QuickSettingUiItem is the composable for each quickSetting item.
In order to populate the quick settings contents, a list of QuickSettingsUiModel needs to be supplied to QuickSettingsUi. This list would contain the needed drawable and string resources for icon, titles, and descriptions of the quick settings items. It also contains the indices of the highlighted items, as well as the clickables for each item.
In PreviewScreen, several such QuickSettingsUiModels are already supplied. They contain the appropriate resources. However, the highlighted indices and clickables need to be supplied by logics in preview module