Fix quick settings back press #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temcguir
approved these changes
Mar 4, 2024
| // Press the device's back button | ||
| uiDevice.pressBack() | ||
|
|
||
| // Assert we're on PreviewScreen by finding the capture button |
There was a problem hiding this comment.
I think the capture button also shows in the quick settings screen. Maybe assert on the flip camera button being visible?
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/ui/TestTags.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+86
to
+89
| when (shouldShowQuickSetting) { | ||
| IsExpandedQuickSetting.NONE -> toggleIsOpen() | ||
| else -> shouldShowQuickSetting = IsExpandedQuickSetting.NONE | ||
| } |
There was a problem hiding this comment.
nit: Can you just put this inline in BackHandler?
BackHandler {
when (shouldShowQuickSetting) {
IsExpandedQuickSetting.NONE -> toggleIsOpen()
else -> shouldShowQuickSetting = IsExpandedQuickSetting.NONE
}
}
There was a problem hiding this comment.
onBack is used again below so I made it into a val
There was a problem hiding this comment.
I only see it being used in the BackHandler below. Where else is it being used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so pressing back button in quick settings screen would navigate back instead of closing the app.
Added two more tests in NavigationTest