Pop from back stack when Settings back arrow is pressed

[temcguir]

When the back arrow is pressed on SettingsScreen, navController.navigate(PREVIEW_ROUTE) was being called, which added SettingsScreen to the back stack. Instead, navController.popBackStack() can be used to return to the previous screen, mimicking the behavior of using the device's back button (or back gesture).

[Kimblebee]

taking a look at this, I had intentionally changed it from using navcontroller.popBackStack() way back in #28

"Fix crashing bug that occurs when attempting to navigate back to the preview screen after using a quick setting that rebinds use cases"

[temcguir]

taking a look at this, I had intentionally changed it from using navcontroller.popBackStack() way back in #28

"Fix crashing bug that occurs when attempting to navigate back to the preview screen after using a quick setting that rebinds use cases"

Thanks for the context. I think the old behavior (popBackStack()) is what we actually want. Do you have repro steps for the old bug? It could be that the cause of the bug was actually fixed since #28.

[Kimblebee]

Thanks for the context. I think the old behavior (popBackStack()) is what we actually want. Do you have repro steps for the old bug? It could be that the cause of the bug was actually fixed since #28.

Yes, my repro steps for the old bug were:

• Open App
• Flip camera (using flip camera button on preview or quick settings screen. Or just any option that rebinds use cases)
• navigate to settings screen
• navigate back to preview

But it seems like the issue has been solved here now! I'm going to poke around some more, but i think this change should be good to go :) Unfortunately at the moment I'm not entirely sure which change has solved this issue.