Single source of truth for camera settings #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
temcguir
commented
Feb 23, 2024
•
temcguir
commented
- Update CameraUseCase to reactive model
- CameraUseCase is only place where default settings will be applied
- PreviewViewModel should not edit CameraAppState
- Setting aspect ratio and flipping camera no longer restarts camera job
CameraUseCase (and CameraXCameraUseCase implementation) will now hold on to CameraAppSettings and react to changes in those settings which are initiated through the CameraUseCase API.
CameraAppState is now owned by CameraUseCase. It will have the single source of truth, and PreviewViewModel will only communicate changes through PreviewUiState, it will not edit CameraAppState directly.
The camera job is started once by runCamera(), any changes that restart the camera will happen contained inside this coroutine. We no longer need to explicitly stop the camera before applying changes that would normally restart the camera.
Also changes FakeCameraUseCase to use a similar reactive model to CameraXCameraUseCase
yasith
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.