Skip to content

Commit

Permalink
Bump AGP to 8.4.2 (#234)
Browse files Browse the repository at this point in the history
* Bump AGP to 8.4.2

* Upgrade deprecated Github actions

* Run workflows on ubuntu-22.04-32core runner

 This runner is set via the repository RUNNER variable
  • Loading branch information
temcguir authored Jun 19, 2024
1 parent 4c03bd1 commit 55de5b6
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 19 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/MergeToMainWorkflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,38 +16,38 @@ env:
jobs:
build:
name: Build
runs-on: ubuntu-latest
runs-on: ${{ vars.RUNNER }}
timeout-minutes: 120
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v1
uses: gradle/actions/wrapper-validation@v3

- name: Set up JDK
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: ${{ env.DISTRIBUTION }}
java-version: ${{ env.JDK_VERSION }}
cache: gradle

- name: Setup Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/actions/setup-gradle@v3

- name: Build all build type and flavor permutations
run: ./gradlew assemble --parallel --build-cache

- name: Upload build outputs (APKs)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-outputs
path: app/build/outputs

- name: Upload build reports
if: always()
continue-on-error: true
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-reports
path: "*/build/reports"
22 changes: 11 additions & 11 deletions .github/workflows/PullRequestWorkflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ env:
jobs:
build:
name: Build
runs-on: ubuntu-latest
runs-on: ${{ vars.RUNNER }}
timeout-minutes: 120
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v2
uses: gradle/actions/wrapper-validation@v3

- name: Set up JDK
uses: actions/setup-java@v4
Expand All @@ -30,7 +30,7 @@ jobs:
cache: gradle

- name: Setup Gradle
uses: gradle/gradle-build-action@v3
uses: gradle/actions/setup-gradle@v3

- name: Build all build type and flavor permutations
run: ./gradlew assemble --parallel --build-cache
Expand All @@ -51,14 +51,14 @@ jobs:

test:
name: Unit Tests
runs-on: ubuntu-latest
runs-on: ${{ vars.RUNNER }}
timeout-minutes: 120
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v2
uses: gradle/actions/wrapper-validation@v3

- name: Set up JDK
uses: actions/setup-java@v4
Expand All @@ -68,7 +68,7 @@ jobs:
cache: gradle

- name: Setup Gradle
uses: gradle/gradle-build-action@v3
uses: gradle/actions/setup-gradle@v3
continue-on-error: true

- name: Run local tests
Expand All @@ -83,7 +83,7 @@ jobs:

android-test:
name: Instrumentation Tests (${{ matrix.device.name }})
runs-on: ubuntu-latest
runs-on: ${{ vars.RUNNER }}
timeout-minutes: 30
strategy:
fail-fast: false
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
run: yes | "$ANDROID_HOME"/cmdline-tools/latest/bin/sdkmanager --licenses || true

- name: Run instrumentation tests
uses: gradle/gradle-build-action@v3
uses: gradle/actions/setup-gradle@v3
with:
arguments: ${{ matrix.device.name }}DebugAndroidTest

Expand All @@ -132,7 +132,7 @@ jobs:
spotless:
name: Spotless Check
runs-on: ubuntu-latest
runs-on: ${{ vars.RUNNER }}
timeout-minutes: 60
steps:
- name: Checkout
Expand All @@ -141,7 +141,7 @@ jobs:
fetch-depth: 0

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v2
uses: gradle/actions/wrapper-validation@v3

- name: Set up JDK
uses: actions/setup-java@v4
Expand All @@ -151,7 +151,7 @@ jobs:
cache: gradle

- name: Setup Gradle
uses: gradle/gradle-build-action@v3
uses: gradle/actions/setup-gradle@v3

- name: Spotless Check
run: ./gradlew spotlessCheck --init-script gradle/init.gradle.kts --parallel --build-cache
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ accompanist = "0.34.0"
# kotlinPlugin and composeCompiler are linked
# See https://developer.android.com/jetpack/androidx/releases/compose-kotlin
kotlinPlugin = "1.9.22"
androidGradlePlugin = "8.4.0-rc01"
androidGradlePlugin = "8.4.2"
protobufPlugin = "0.9.4"

androidxActivityCompose = "1.8.2"
Expand Down

0 comments on commit 55de5b6

Please sign in to comment.