-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example does not work on windows. #121
Comments
See #9 |
We welcome patches, especially for Windows since none the current contributors (myself including) develop on Windows. For this case where the command line to zip is to long it could be changed to use -@ and pass the arguments on stdin. |
The relevant code is here: j2cl/jre/java/package_sources.bzl Lines 22 to 37 in fd4de17
The arguments could be converted to a file arg instead as well. |
The community developed maven plugin works on Windows (without WSL), and also has features the bazel plugin does not, such as testing and iterative-development source maps. I've also submitted a PR for a live-reloading dev server. So soon it will get even better! I must say that while I'm a big fan of J2CL, I absolutely and passionately hate bazel. But that is a bikeshed not productive to discuss. |
Off topic: |
@tbroyer I want to start contributing to this project. |
Hello,
I tried following your getting started under https://github.com/google/j2cl/blob/master/docs/getting-started.md
The following happens on my machine (Windows (sadly)). Installing bazelisk through npm or chocolatey does not result in any different outcome.
Using WSL2:
If using MSYS2:
My suspicion is that in both cases you are trying to put lots of stuff on a command line and that on Windows the maximum is less than under Linux or macOS. As Windows is probably pretty rare, I hit this bug. Sooner or later it may hit anyone. Putting long list of files on a command line is not very reliable.
Regards
The text was updated successfully, but these errors were encountered: