-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the workflow under Windows. #9
Comments
WSL is not an option for us, we are not permitted to install something like that and also we are on Win7 not 10. We do not have any experience with Basel so it looks like we will have to wait until this issue has been resolved :-( |
The GWT Community has started work on Maven and Gradle plugins. They are designed towards GWT 3 though, not "pure J2Cl". |
As a start, I can describe my WIN 10 Bazel setup based on Using Bazel on Windows. Would external-link to "md file" be useful? |
@vojkog Did you try everything explained in README.md of J2CL ? If yes, was everything successful on Win 10 for you or not ? |
@markposterone see #7 |
Basel is possible to install on Windows as pointed by @vojkog. The GWT community is working hard on Maven but it seams that nobody is looking into "some path handling in J2CL does not work well with windows paths" as they expect that creators of J2CL will take a look at this problem. |
We would like the community to take on making J2CL work in Windows natively. None of the core developers uses Windows machines. We do not consider this a blocker since it works under WSL in Windows 10. W.r.t the path handling I referred to in the previous comment is mostly constrained to the the reading of the source files. It is very localized and should be pretty straightforward to debug and fix. |
I found and fixed the first file/path issue, while running j2cl native with Windows 10 ... added the following fix ".replace('\\', '/')" here "com.google.j2cl.generator.OutputGeneratorStage#generateOutputs:82" String typeRelativePath = getRelativePath(type).replace('\\', '/'); Not sure if this fix is well placed, but is corrects the issue (looking up an windows path in a map with unix paths)... Btw. after this, I found a next issue (but only warnings, but tons of it):
Does somebody from the core team has may a code-pointer to check it? |
I found and fixed the first file/path issue, while running j2cl native with Windows 10 ... added the following fix ".replace('\\', '/')" here "com.google.j2cl.generator.OutputGeneratorStage#generateOutputs:87" String typeRelativePath = getRelativePath(type).replace('\\', '/'); Not sure if this fix is well placed, but is corrects the issue (looking up an windows path in a map with unix paths)...
…ogle#3206 And fixes parts of "Support the workflow under Windows. google#9" (google/j2cl#9) from j2cl
I added a PR to j2cl and one to closure-compiler (for the SOURCEMAP_RESOLVE_FAILED "WARNING") to fix both issues I found. |
…ogle#3206 And fixes parts of "Support the workflow under Windows. google#9" (google/j2cl#9) from j2cl
…ogle#3206 And fixes parts of "Support the workflow under Windows. google#9" (google/j2cl#9) from j2cl
See also google/j2cl#9. Fixes #3206. Closes #3207. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=230635801
See also google/j2cl#9. Fixes google#3206. Closes google#3207. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=230635801
Fix to '/' for all operating system (including windows) in getRelativePath and getAbsolutePath, because the lookup map is using '/' as well
Could we update the closure-compiler to version to v20190215 to solve |
Use hardcoded '/' as the file separator in getRelativePath and getAbsolutePath. For file operations, Java will interpret the Unix file separator ("/") as if it were the file separator even when running in windows. Internally paths are used as keys and need to be consistent. Some of these paths are constructed programmatically, others are read from zip file directories, etc. It is better to adopt the simple standard to always use "/" as the separator. Closes #26 PiperOrigin-RevId: 236383428
What's the status of this ? |
I am working on updating Closure rules workspace to work with the newer Closure release; should be completed next week. |
Closure compiler version is updated to latest release in bazelbuild/rules_closure#347. |
As of 2021Jan13, I attempted to setup the j2cl in Windows 10. Following the "Getting Started" guide and installing bazel for Windows 10, the setup was successful. But, I saw an error related to "zipper.exe Argument list too long". d:\j2cl\samples\helloworld> bazel build src/main/java/com/google/j2cl/samples/helloworld:helloworld Error message seems to be related to bazel and may not related to j2cl. Someone please shed light on this. Does anyone faced this issue ? |
Yes, see #121 |
The current release does not work under Windows.
There are a few known issues:
Detailed documentation on how to setup under Windows would be very helpful and address the first point.
For now we recommend to use WSL under Windows 10.
The text was updated successfully, but these errors were encountered: