Add arith.select
Pattern to --secret-to-bgv
#825
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following rewrite pattern:
However, as-is, this pattern actually produces invalid IR:
%c
has (element/self) typei1
while%t
and%f
can have any IntegerLike type, e.g.,i32
. In the current TypeConverter, this means that the condition is mapped to a ciphertext with encoding#lwe.polynomial_evaluation_encoding<cleartext_start = 1, cleartext_bitwidth = 1>
while the other values are mapped to ciphertexts with encoding#lwe.polynomial_evaluation_encoding<cleartext_start = 32, cleartext_bitwidth = 32>
. Sincebgv.mul
requires the types of its operands to match, this is invalid IR.In the current draft, I've simply hardcoded the typeconverter to map everything to 32 bits (that's why this is a Draft PR only for now), but we'll need to think about how to handle such cases. I think this is a special case of "what is the plaintext-FHE semantics mapping" (Step 1 in #785).