Add Chebyshev interpolation #1367
Merged
+234
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoutLegiest
approved these changes
Feb 7, 2025
Notes: - Adds pocketfft (numpy's underlying FFT lib) to workspace dependencies - Slight improvements to Polynomial data structures - Adds simple conversion from Chebyshev basis to monomial basis
Added a citation. I think the method in this PR is not novel (it's a very old and well known technique) and the main routine (coming next) is the Caratheodory-Fejer approximation which has proper citations. |
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Chebyshev interpolation routine, which is a subroutine needed for Caratheodory-Fejer approximation.
Adds a new (very lightweight) dependency:
pocketfft, the fft implementation used by numpy.