Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT gate emission in the packed API #1081

Merged
merged 1 commit into from
Nov 13, 2024
Merged

NOT gate emission in the packed API #1081

merged 1 commit into from
Nov 13, 2024
+105 −22

Conversation

WoutLegiest
Copy link
Collaborator

Extending the TfheRustBool Emitter that it also support to process not gates in a parallel way

@WoutLegiest WoutLegiest force-pushed the not_packed branch 3 times, most recently from 4d827f7 to 3bb48a6 Compare November 9, 2024 00:22
j2kun
j2kun approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and straightforward. LGTM!

tests/Dialect/TfheRustBool/Emitters/emit_tfhe_rust_bool.mlir Outdated Show resolved Hide resolved
tests/Dialect/TfheRustBool/Emitters/emit_tfhe_rust_bool_packed.mlir Show resolved Hide resolved
tests/Dialect/TfheRustBool/IR/ops.mlir Outdated Show resolved Hide resolved
tests/Examples/tfhe_rust_bool/fpga/test_fully_connected.mlir Outdated Show resolved Hide resolved
lib/Target/TfheRustBool/TfheRustBoolEmitter.cpp Outdated Show resolved Hide resolved
@WoutLegiest WoutLegiest force-pushed the not_packed branch 2 times, most recently from 9eb3fb7 to da4e1f1 Compare November 12, 2024 19:45
@j2kun j2kun changed the title NOT gate emittion in the packed API NOT gate emission in the packed API Nov 12, 2024
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Nov 12, 2024
@copybara-service copybara-service bot merged commit ddfddb4 into google:main Nov 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j2kun j2kun j2kun approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoutLegiest @j2kun