Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone of https://github.com/google/guava/pull/6730 but without the prod change -- should fail Windows testing #6732

Closed
wants to merge 5 commits into from

Conversation

cpovirk
Copy link
Member

@cpovirk cpovirk commented Sep 26, 2023

Fix Files.createTempDir and FileBackedOutputStream under Windows services, a rare use case.

Fixes #6634

Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 and a newer version....

RELNOTES=io: Fixed Files.createTempDir and FileBackedOutputStream under Windows services, a rare use case.
PiperOrigin-RevId: 568604081

…ting

Fix `Files.createTempDir` and `FileBackedOutputStream` under Windows _services_, a rare use case.

Fixes #6634

Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 *and* a newer version....

RELNOTES=`io`: Fixed `Files.createTempDir` and `FileBackedOutputStream` under [Windows _services_, a rare use case](#6634).
PiperOrigin-RevId: 568604081
@cpovirk
Copy link
Member Author

cpovirk commented Sep 26, 2023

Good, failed as hoped:

testBogusSystemPropertiesUsername(com.google.common.io.FilesCreateTempDirTest)  Time elapsed: 0.015 sec  <<< FAILURE!
expected to be true
	at com.google.common.io.FilesCreateTempDirTest.testBogusSystemPropertiesUsername(FilesCreateTempDirTest.java:101)

@cpovirk cpovirk closed this Sep 26, 2023
@cpovirk cpovirk deleted the fail-from-no-prod-change-568604081 branch September 26, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant