Code

Fix error prone warns#2320

Code

Merged

eamonnmcmanus merged 57 commits intogoogle:mastergoogle/gson:masterfrom MaicolAntali:fix-error-prone-warnsMaicolAntali/gson:fix-error-prone-warnsCopy head branch name to clipboardMar 1, 2023

+225-193

Commits

Commits on Feb 18, 2023

• Adds @SuppressWarnings("NarrowingCompoundAssignment")

  MaicolAntali

  committed
  18336d0

  Copy full SHA for 18336d0

• Adds @SuppressWarnings("TypeParameterUnusedInFormals")

  MaicolAntali

  committed
  0c2f8c3

  Copy full SHA for 0c2f8c3

• Adds @SuppressWarnings("JavaUtilDate")

  MaicolAntali

  committed
  7f64bf3

  Copy full SHA for 7f64bf3

• Adds a limit to String.split()

  MaicolAntali

  committed
  f34c35d

  Copy full SHA for f34c35d

• Add error_prone_annotations to the pom.xml

  MaicolAntali

  committed
  5e6a279

  Copy full SHA for 5e6a279

• Adds @InlineMe(...) to deprecated methods

  MaicolAntali

  committed
  682b369

  Copy full SHA for 682b369

• Adds @SuppressWarnings("ImmutableEnumChecker")

  MaicolAntali

  committed
  41e0c28

  Copy full SHA for 41e0c28

• Adds @SuppressWarnings("ModifiedButNotUsed")

  MaicolAntali

  committed
  b6965d1

  Copy full SHA for b6965d1

• Adds @SuppressWarnings("MixedMutabilityReturnType")

  MaicolAntali

  committed
  04feff6

  Copy full SHA for 04feff6

• Removes an unused import

  MaicolAntali

  committed
  5bd180d

  Copy full SHA for 5bd180d

Commits on Feb 19, 2023

• Adds requires to module-info.java

  MaicolAntali

  committed
  373525d

  Copy full SHA for 373525d

• Adds ErrorProne link into pom.xml

  MaicolAntali

  committed
  bd60abf

  Copy full SHA for bd60abf

• Remove unused imports

  Show description for 5e1e970
  MaicolAntali

  committed
  5e1e970

  Copy full SHA for 5e1e970

• Adds @SuppressWarnings("EqualsGetClass")

  MaicolAntali

  committed
  f3c4763

  Copy full SHA for f3c4763

• Excludes from proto just the generated code.

  Show description for 71a75b8
  MaicolAntali

  committed
  71a75b8

  Copy full SHA for 71a75b8

• Removes an unused variable

  Show description for a1beaf2
  MaicolAntali

  committed
  a1beaf2

  Copy full SHA for a1beaf2

• Fixes the BadImport warn into ProtosWithAnnotationsTest

  MaicolAntali

  committed
  9c5073f

  Copy full SHA for 9c5073f

• Fixes the BadImport warns into ProtosWithAnnotationsTest

  MaicolAntali

  committed
  2aad0bc

  Copy full SHA for 2aad0bc

• Enables ErrorProne in gson/src/test.*

  Show description for ba27715
  MaicolAntali

  committed
  ba27715

  Copy full SHA for ba27715

• Fixes UnusedVariable warns

  Show description for e3d65bc
  MaicolAntali

  committed
  e3d65bc

  Copy full SHA for e3d65bc

• Fixes JavaUtilDate warns

  Show description for d1c0554
  MaicolAntali

  committed
  d1c0554

  Copy full SHA for d1c0554

• Fixes EqualsGetClass warns

  Show description for 7769c75
  MaicolAntali

  committed
  7769c75

  Copy full SHA for 7769c75

• Replaces pattern matching for instanceof with casts

  MaicolAntali

  committed
  a8cff33

  Copy full SHA for a8cff33

Commits on Feb 22, 2023

• Fixes JdkObsolete warns

  Show description for eb05e0d
  MaicolAntali

  committed
  eb05e0d

  Copy full SHA for eb05e0d

• Fixes ClassCanBeStatic warns

  Show description for ef27eb4
  MaicolAntali

  committed
  ef27eb4

  Copy full SHA for ef27eb4

• Fixes UndefinedEquals warns

  Show description for 69b34be
  MaicolAntali

  committed
  69b34be

  Copy full SHA for 69b34be

• Fixes GetClassOnEnum warns

  Show description for 7a20385
  MaicolAntali

  committed
  7a20385

  Copy full SHA for 7a20385

• Fixes ImmutableEnumChecker warns

  Show description for 4627307
  MaicolAntali

  committed
  4627307

  Copy full SHA for 4627307

• Fixes StaticAssignmentOfThrowable warns

  Show description for 13de98d
  MaicolAntali

  committed
  13de98d

  Copy full SHA for 13de98d

• Fixes AssertionFailureIgnored warns

  Show description for 3ae4fac
  MaicolAntali

  committed
  3ae4fac

  Copy full SHA for 3ae4fac

• Fixes ModifiedButNotUsed warns

  Show description for 661eae8
  MaicolAntali

  committed
  661eae8

  Copy full SHA for 661eae8

• Fixes MissingSummary warns

  Show description for 2742881
  MaicolAntali

  committed
  2742881

  Copy full SHA for 2742881

• Fixes FloatingPointLiteralPrecision warns

  Show description for 7d688ed
  MaicolAntali

  committed
  7d688ed

  Copy full SHA for 7d688ed

• Fixes StringSplitter warns

  Show description for 67a8edf
  MaicolAntali

  committed
  67a8edf

  Copy full SHA for 67a8edf

• Fixes EmptyCatch warns

  Show description for b92cb96
  MaicolAntali

  committed
  b92cb96

  Copy full SHA for b92cb96

• Fixes UnicodeEscape warns

  Show description for dcb277e
  MaicolAntali

  committed
  dcb277e

  Copy full SHA for dcb277e

• Fixes EmptyBlockTag warns

  Show description for 6dee398
  MaicolAntali

  committed
  6dee398

  Copy full SHA for 6dee398

• Fixes LongFloatConversion warns

  Show description for 682d5df
  MaicolAntali

  committed
  682d5df

  Copy full SHA for 682d5df

• Fixes LongDoubleConversion warns

  Show description for c1681bf
  MaicolAntali

  committed
  c1681bf

  Copy full SHA for c1681bf

• Fixes TruthAssertExpected warns

  Show description for 69dcd03
  MaicolAntali

  committed
  69dcd03

  Copy full SHA for 69dcd03

• Fixes UnusedMethod warns

  Show description for 03e86d6
  MaicolAntali

  committed
  03e86d6

  Copy full SHA for 03e86d6

• Fixes UnusedTypeParameter warns

  Show description for 1feefb4
  MaicolAntali

  committed
  1feefb4

  Copy full SHA for 1feefb4

• Fixes CatchFail warns

  Show description for 7ac4465
  MaicolAntali

  committed
  7ac4465

  Copy full SHA for 7ac4465

• Fixes MathAbsoluteNegative warns

  Show description for 92972bf
  MaicolAntali

  committed
  92972bf

  Copy full SHA for 92972bf

• Fixes LoopOverCharArray warns

  Show description for 2167d4c
  MaicolAntali

  committed
  2167d4c

  Copy full SHA for 2167d4c

• Fixes HidingField warns

  Show description for 126b1b5
  MaicolAntali

  committed
  126b1b5

  Copy full SHA for 126b1b5

• Implements code review feedback

  MaicolAntali

  committed
  4aaefea

  Copy full SHA for 4aaefea

• Implements code review feedback

  Show description for f1c5591
  MaicolAntali

  committed
  f1c5591

  Copy full SHA for f1c5591

• Enable ErrorProne in extra

  Show description for 7590168
  MaicolAntali

  committed
  7590168

  Copy full SHA for 7590168

• Fix the JavaUtilDate warns

  Show description for 1bb54c4
  MaicolAntali

  committed
  1bb54c4

  Copy full SHA for 1bb54c4

Commits on Feb 23, 2023

• Implements code review feedback

  MaicolAntali

  committed
  a507512

  Copy full SHA for a507512

• Removes redundant new-line

  MaicolAntali

  committed
  bd2916e

  Copy full SHA for bd2916e

Commits on Feb 24, 2023

• Implements code review feedback

  MaicolAntali

  committed
  13ab165

  Copy full SHA for 13ab165

• Adds JDK11 to run test with --release 11

  MaicolAntali

  committed
  a7cca38

  Copy full SHA for a7cca38

• Revert "Adds JDK11 to run test with --release 11"

  Show description for 5dbbbee
  MaicolAntali

  committed
  5dbbbee

  Copy full SHA for 5dbbbee

Commits on Feb 28, 2023

• Merge branch 'master' into fix-error-prone-warns

  MaicolAntali

  authored
  f89d42a

  Copy full SHA for f89d42a

Commits on Mar 1, 2023

• Merge branch 'master' into fix-error-prone-warns

  MaicolAntali

  authored
  039bf62

  Copy full SHA for 039bf62