-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out job cards into Composables for new data entry points #2892
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sufyanAbbasi so cool to see this is working! A few suggestions/tweaks. Once we do those, I think we can submit as is without too much UI churn for now. @rawbzz Is still finalizing the latest designs, but what you have here takes us much closer.
ground/src/main/java/com/google/android/ground/ui/home/mapcontainer/cards/JobSelectionDialog.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/ground/ui/home/mapcontainer/HomeScreenMapContainerFragment.kt
Show resolved
Hide resolved
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/home/mapcontainer/HomeScreenMapContainerFragment.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2892 +/- ##
============================================
- Coverage 62.57% 61.23% -1.34%
- Complexity 1207 1217 +10
============================================
Files 267 268 +1
Lines 6367 6576 +209
Branches 879 901 +22
============================================
+ Hits 3984 4027 +43
- Misses 1833 1988 +155
- Partials 550 561 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @sufyanAbbasi 🥳 A few nits, otherwise LGTM!
...c/main/java/com/google/android/ground/ui/home/mapcontainer/HomeScreenMapContainerFragment.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/ground/ui/home/mapcontainer/HomeScreenMapContainerFragment.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/MapUiData.kt
Outdated
Show resolved
Hide resolved
…ound-android into sufy/2446/new-loi-flow
Added "add_site" and two more strings (untranslated)
Added "add_site" and two more strings (untranslated)
Remaining translations added ("unnamed_job" and "job_site_icon").
Remaining translations added ("unnamed_job" and "job_site_icon").
Remaining translations added ("unnamed_job" and "job_site_icon").
Would you be able to add tests for modified lines? We can focus on the ones reported here by codecov if it helps. |
Fixes #2446
Reimplements the entire add LOI/selection UX to match the new designs (see above issue).
add_data
andadd_site
.@gino-m PTAL?