MacOS Support #592
MacOS Support #592
Conversation
vyeevani
commented
Oct 3, 2024
vyeevani
commented
- support for bazelmod
- building wheels with bazel
- support for macOS via not standard array_record library
- support for ci tagging and versioning
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PiperOrigin-RevId: 698543187
- building wheels with bazel - support for macOS via not standard array_record library - support for ci tagging and versioning
|
thanks for the PR, but it is not backwards compatible -- with this change we will lose platform tags and linux arm64 build which is required for latest NVidia GPUs. Do you think these can be added? Also, is there a way to avoid specifying requirements for every build rule? |
|
Could you elaborate on the platform tags? I'm not entirely sure what you meant by that. On the backwards compatibility front, totally agree that it's not -- this was meant to be for me testing locally on my laptop then deploying to a cloud machine where I'd use the official grain image. If there's interest in getting this merged, I could spin on the issues that you've raised. However, if it's fundamentally incompatible with google's internal infra for cutting releases, then I'd rather just leave my fork up and sync it whenever needed. |
