Made mock modifiers inheritable #4689
Open
+86
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For large codebases, it can be very annoying to define Mocks:
Using such mocks will create
Uninteresting Mock functions
warnings when any of the mock methods are used.Possible solutions include implementing
EXPECT_CALL
for each and every mock methods of this class. This can be very teadious and unnecessary when an actual implementation of the mock methods are not needed.Alternatively, the
NiceMock
modifier can be used. This can however create very repetative code (Yes, i know#define
s andusing
s can be used), it would be nice if the modifiers can directly be applied directly to the class definition as so:This feature is implementated in this pull request and i would be happy if this code can be reviewed and merged.
Do i need to update the gtest/gmock docs?
Thanks.