Fix the parsing logic of matches_pattern! to support _ at the top level in braced enums.
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_755381147
branch
from
c7b3545 to
5544678
Compare
…evel in braced enums.
In the current parsing logic, the `_` field in pattern `AsEnum::Foo { a_field : _ }` is parsed as None, and as a result no FieldMatcher is generated, and the internal `is()` matcher only evaluates the innerMatcher(the field_matcher).
With the current change, when no field_matcher is present, the matches pattern macro verifies the variant of the Enum with `pattern_only()` matcher.
Toward #626
PiperOrigin-RevId: 757644200
copybara-service
bot
force-pushed
the
test_755381147
branch
from
5544678 to
1d64715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the parsing logic of matches_pattern! to support
_at the top level in braced enums.In the current parsing logic, the
_field in patternAsEnum::Foo { a_field : _ }is parsed as None, and as a result no FieldMatcher is generated, and the internalis()matcher only evaluates the innerMatcher(the field_matcher).With the current change, when no field_matcher is present, the matches pattern macro verifies the variant of the Enum with
pattern_only()matcher.Toward #626