Use DisjunctionMatcher for any![] macro. #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacotg
force-pushed
the
any_with_disjunction
branch
2 times, most recently
from
2eca8c4 to
d26ee50
Compare
bjacotg
force-pushed
the
any_with_disjunction
branch
from
d26ee50 to
2ef3ca4
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
65af6d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update:
any!to rely onDisjunctionMatcherand not onAnyMatcher(which is removed).DisjunctionMatcherto generateDescriptionmore similar toAnyMatcher.any. This should be implemented asnot(anything())which is a surprising behavior.all!since it is used in thematches_pattern!often with empty matcher list.This PR will allow the usage of
any!where a matcher is constrain with HRTB is expected. See #323 for more details.