Introduce a matcher for byte sequences which represent UTF-8 encoded strings #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…strings. This allows the use of all matchers for string types on such types. These types come up often when working with various types of I/O, so matching on them can be useful. This currently only supports UTF-8 encoding, but could be extended for other encodings with the addition of a suitable (presumably optional) dependency.
This fixes the lifetime problems in `IsEncodedStringMatcher` at the cost of an extra allocation: the input must be copied to a `Vec<u8>`, then converted to a `String`.
hovinen
force-pushed
the
add-matcher-for-utf8-byte-sequences
branch
from
8a271e6 to
e6a8c7f
Compare
bjacotg
reviewed
Nov 30, 2023
copybara-service
bot
closed this pull request by merging all changes
into
main
in
281b6b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of all matchers for string types on such types. These types come up often when working with various types of I/O, so matching on them can be useful.
This currently only supports UTF-8 encoding, but could be extended for other encodings with the addition of a suitable (presumably optional) dependency.
Note: Currently, due to #323, this only compiles with an additional change which introduces extra allocation on each
matchescall. I've put that in a separate commit.