fix: Unchecked error in std.manifestYamlDoc(). #800
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnbartholomew, can you please get this merged? :) |
|
Hello, how can I bring someone's attention to this issue? :-) The fix itself is clear and obvious, but I guess I could add a test for if needed. Cheers. |
Problem: A recursive call within manifestYamlDoc() might fail but the
return value is not checked.
Reproducible with:
```
$ jsonnet-2f73f61 -e "std.manifestYamlDoc({ x: { y: error 'foo' } }, quote_keys=false)"
"x:\n "
```
Expected:
```
$ jsonnet-0.20.0 -e "std.manifestYamlDoc({ x: { y: error 'foo' } }, quote_keys=false)"
RUNTIME ERROR: foo
<cmdline>:1:31-42 object <anonymous>
...
```
johnbartholomew
force-pushed
the
fix-manifestYamlDoc-error-check
branch
from
b957d71 to
80c7c4a
Compare
|
Sorry for the silence here, and also for missing this fix for the 0.21 release. I've rebased it to master, and will merge assuming CI checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: A recursive call within manifestYamlDoc() might fail but the return value is not checked.
Reproducible with:
Expected: