fix: fix conversion from int to float64 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
cannot convert v (variable of type interface{}) to type float64: need type assertion
```
suzuki-shunsuke
commented
Jun 3, 2024
Comment on lines
+952
to
+961
| case int: | ||
| return makeDoubleCheck(i, float64(v)) | ||
| case int8: | ||
| return makeDoubleCheck(i, float64(v)) | ||
| case int16: | ||
| return makeDoubleCheck(i, float64(v)) | ||
| case int32: | ||
| return makeDoubleCheck(i, float64(v)) | ||
| case int64: | ||
| return makeDoubleCheck(i, float64(v)) |
There was a problem hiding this comment.
We can't merge these case for type assertion.
If these case are merged, the type of v becomes interface{} so we can't convert the value to float64.
cannot convert v (variable of type interface{}) to type float64: need type assertion
sbarzowski
approved these changes
Jun 9, 2024
|
Thank you! |
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
* fix: fix conversion from int to float64
* fix: fix a compile error
```
cannot convert v (variable of type interface{}) to type float64: need type assertion
```
bastjan
added a commit
to vshn/espejote
that referenced
this pull request
Mar 31, 2025
Current go-jsonnet only supports `float64` as NativeFunction return values. See <google/go-jsonnet#761> and <google/go-jsonnet#753>. This PR ensures the `__internal_use_espejote_lib_function_apply_json_patch` function only returns `float64` by switching the kubernetes json unmarshaler to the `encoding/json` unmarshaler. As we unmarshal into `any` we don't need any special handling from the kubernetes unmarshaller.
2 tasks
bastjan
added a commit
to vshn/espejote
that referenced
this pull request
Mar 31, 2025
Current go-jsonnet only supports `float64` as NativeFunction return values. See <google/go-jsonnet#761> and <google/go-jsonnet#753>. This PR ensures the `__internal_use_espejote_lib_function_apply_json_patch` function only returns `float64` by switching the kubernetes json unmarshaler to the `encoding/json` unmarshaler. As we unmarshal into `any` we don't need any special handling from the kubernetes unmarshaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #752
This pull request is similar to #741 , but this pull request fixes a bug of #741 .