Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change golangci-lint output format due to deprecation #3279

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

felixlut
Copy link
Contributor

@felixlut felixlut commented Sep 21, 2024

As specified in the GitHub Actions logs for the linter, the github-actions output format is deprecated, and colored-line-number should be used instead. Deprecation was done in golangci/golangci-lint#4726

github-actions is deprecated, and colored-line-number should be used instead
@gmlewis gmlewis changed the title chore: change golangci-lint output format due to deprecation chore: Change golangci-lint output format due to deprecation Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2b8c7fa) to head (2256497).
Report is 116 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
- Coverage   97.72%   92.94%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11669    -1721     
==========================================
- Hits        13085    10846    -2239     
- Misses        215      729     +514     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.
Merging.

@gmlewis gmlewis merged commit 46f1127 into google:master Sep 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants