Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "performed_via_github_app" and "requested_team" in IssueEvent #2946

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

Shyclyde
Copy link
Contributor

@Shyclyde Shyclyde commented Oct 1, 2023

Issue Source

#2945 mentions the reasoning for this PR.

Why

"performed_via_github_app" and "requested_team" are valuable results in the issue events response (when available) to determine more about the event. It also keeps the struct up to date with the API response.

What

  • Adds these values to the IssueEvent struct.
  • Adds test cases for added values.
  • Restructures relevant test cases slightly to match the order of the given/want for easier reference.

Other notes

Ran all available test scripts, updated accordingly. Tests passing.

@google-cla
Copy link

google-cla bot commented Oct 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Shyclyde !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #2946 (954e7ed) into master (8cd452b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2946   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         145      145           
  Lines       12720    12720           
=======================================
  Hits        12490    12490           
  Misses        156      156           
  Partials       74       74           
Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/issues_events.go 100.00% <ø> (ø)
github/issues_timeline.go 100.00% <ø> (ø)

@Shyclyde Shyclyde changed the title Support PerformedViaGithubApp and RequestedTeam in IssueEvent Add support for "performed_via_github_app" and "requested_team" in IssueEvent Oct 1, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 3, 2023

Thank you, @WillAbides !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 3, 2023
@gmlewis gmlewis merged commit 5224e34 into google:master Oct 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants