Refactor config Unmarshal methods. #271
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use json.RawMessage to clean logic distinguishing literal and regexp matchers * Add tag validation that both key and value are set.
1 task
PurelyApplied
commented
Jan 29, 2021
| } | ||
| ft.Key = val | ||
| case "val", "value": | ||
| if ft.Key != "" { |
There was a problem hiding this comment.
Obvious typo
PurelyApplied
commented
Jan 29, 2021
Comment on lines
+188
to
+190
| s.Package = vacuousMatcher{} | ||
| s.Type = vacuousMatcher{} | ||
| s.Field = vacuousMatcher{} |
There was a problem hiding this comment.
Might read better as = nil, use != nil checks below, and update nil to vacuous during final validation. But it's a draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>