This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Fix use of pointer into string after assignment #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Great, thanks for testing it. Edit: whoops, should have gone to the commit comment, github can be confusing. |
lenhardt
added a commit
that referenced
this pull request
Nov 30, 2015
Fix use of pointer into string after assignment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to get squash to work with MSVC (quixdb/squash#145), and gipfeli was one of the plugins that crashed. After failing to debug it in Windows, I ran it through Valgrind, and found this.
It looks like
prev_blockis set to point into the data of the stringinput_block, which is then assigned a different value, which should invalidate all pointers.