Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary language added to Playwrite AR and CO Guides #8821

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Primary language added to Playwrite AR and CO Guides #8821

merged 1 commit into from
Jan 10, 2025

Conversation

vv-monsalve
Copy link
Collaborator

Fixes the first item of #8724

@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.13.0a7

Check results

[16] PlaywriteARGuides-Regular.ttf
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets. googlefonts/metadata/menu_and_latin
  • 🔥 FAIL

    Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".


    [code: missing]
🔥 FAIL Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
  • 🔥 FAIL

    The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 2079 when it should be at most 2000


    [code: bad-hhea-range]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron alt_caron

  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Check if each glyph has the recommended amount of contours. contour_count
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 6	Expected: 2

    

  • 

    Glyph name: quotedbl	Contours detected: 6	Expected: 2
    

    • 

  • 

    Glyph name: numbersign	Contours detected: 6	Expected: 2
    

    • 

  • 

    Glyph name: dollar	Contours detected: 6	Expected: 1, 3 or 5
    

    • 

  • 

    Glyph name: percent	Contours detected: 9	Expected: 4 or 5
    

    • 

  • 

    Glyph name: ampersand	Contours detected: 7	Expected: 1, 2 or 3
    

    • 

  • 

    Glyph name: quotesingle	Contours detected: 5	Expected: 1
    

    • 

  • 

    Glyph name: parenleft	Contours detected: 5	Expected: 1
    

    • 

  • 

    Glyph name: parenright	Contours detected: 5	Expected: 1
    

    • 

  • 

    Glyph name: asterisk	Contours detected: 5	Expected: 1 or 4
    

    • 

  • 

    715 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check there are no overlapping path segments overlapping_path_segments
  • ⚠️ WARN

    The following glyphs have overlapping path segments:

* cnct.mod_n_o: L<<0.0,-565.0>--<0.0,-555.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,1065.0>--<0.0,1075.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,-565.0>--<0.0,-555.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,1065.0>--<0.0,1075.0>> has the same coordinates as a previous segment.

* cnct.mod_n_e: L<<0.0,-565.0>--<0.0,-555.0>> has the same coordinates as a previous segment.

* cnct.mod_n_e: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* 634 more.

Use -F or --full-lists to disable shortening of long lists.

[code: overlapping-path-segments]
⚠️ WARN Glyph names are all valid? valid_glyphnames
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    circumflexcomb_hookabovecomb.case


    [code: legacy-long-names]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext
  • U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext
  • U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
  • U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
  • U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
  • U+0105 LATIN SMALL LETTER A WITH OGONEK: try adding latin-ext
  • U+0106 LATIN CAPITAL LETTER C WITH ACUTE: try adding latin-ext
  • U+0107 LATIN SMALL LETTER C WITH ACUTE: try adding latin-ext
  • U+0108 LATIN CAPITAL LETTER C WITH CIRCUMFLEX: try adding latin-ext
  • U+0109 LATIN SMALL LETTER C WITH CIRCUMFLEX: try adding latin-ext 263 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Check the direction of the outermost contour in each glyph outline_direction
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_c_z has a counter-clockwise outer contour

* cnct.cnt_c_z has a counter-clockwise outer contour

* cnct.cnt_f_z has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_z has a counter-clockwise outer contour

* 468 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? outline_semi_vertical
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* A.cur (U+0041): L<<880.0,581.0>--<879.0,175.0>>

* A.cur.ini: L<<880.0,581.0>--<879.0,236.0>>

* H.cur.ini: L<<875.0,628.0>--<876.0,222.0>>

* H.cur: L<<824.0,178.0>--<823.0,601.0>>

* H.cur: L<<877.0,631.0>--<878.0,179.0>>

[code: found-semi-vertical]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/playwritearguides


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/playwritearguides/PlaywriteARGuides-Regular.ttf
Dehinted Size 345.1kb
Hinted Size 345.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 9 62 6 159 0
0% 0% 1% 4% 26% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.13.0a7

Check results

[17] PlaywriteCOGuides-Regular.ttf
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets. googlefonts/metadata/menu_and_latin
  • 🔥 FAIL

    Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".


    [code: missing]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron alt_caron

  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Check if each glyph has the recommended amount of contours. contour_count
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 6	Expected: 2

    

  • 

    Glyph name: quotedbl	Contours detected: 6	Expected: 2
    

    • 

  • 

    Glyph name: numbersign	Contours detected: 6	Expected: 2
    

    • 

  • 

    Glyph name: dollar	Contours detected: 6	Expected: 1, 3 or 5
    

    • 

  • 

    Glyph name: percent	Contours detected: 9	Expected: 4 or 5
    

    • 

  • 

    Glyph name: ampersand	Contours detected: 7	Expected: 1, 2 or 3
    

    • 

  • 

    Glyph name: quotesingle	Contours detected: 5	Expected: 1
    

    • 

  • 

    Glyph name: parenleft	Contours detected: 5	Expected: 1
    

    • 

  • 

    Glyph name: parenright	Contours detected: 5	Expected: 1
    

    • 

  • 

    Glyph name: asterisk	Contours detected: 5	Expected: 1 or 4
    

    • 

  • 

    715 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check there are no overlapping path segments overlapping_path_segments
  • ⚠️ WARN

    The following glyphs have overlapping path segments:

* cnct.mod_n_o: L<<0.0,-520.0>--<0.0,-510.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.

* cnct.mod_n_o: L<<0.0,1020.0>--<0.0,1030.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,-520.0>--<0.0,-510.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,500.0>--<0.0,505.0>> has the same coordinates as a previous segment.

* cnct.mod_n_b: L<<0.0,1020.0>--<0.0,1030.0>> has the same coordinates as a previous segment.

* cnct.mod_n_e: L<<0.0,-520.0>--<0.0,-510.0>> has the same coordinates as a previous segment.

* cnct.mod_n_e: L<<0.0,0.0>--<0.0,20.0>> has the same coordinates as a previous segment.

* 634 more.

Use -F or --full-lists to disable shortening of long lists.

[code: overlapping-path-segments]
⚠️ WARN Glyph names are all valid? valid_glyphnames
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    circumflexcomb_hookabovecomb.case


    [code: legacy-long-names]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext
  • U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext
  • U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
  • U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: vietnamese, latin-ext
  • U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
  • U+0105 LATIN SMALL LETTER A WITH OGONEK: try adding latin-ext
  • U+0106 LATIN CAPITAL LETTER C WITH ACUTE: try adding latin-ext
  • U+0107 LATIN SMALL LETTER C WITH ACUTE: try adding latin-ext
  • U+0108 LATIN CAPITAL LETTER C WITH CIRCUMFLEX: try adding latin-ext
  • U+0109 LATIN SMALL LETTER C WITH CIRCUMFLEX: try adding latin-ext 263 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Check the direction of the outermost contour in each glyph outline_direction
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_b_z has a counter-clockwise outer contour

* cnct.cnt_c_z has a counter-clockwise outer contour

* cnct.cnt_c_z has a counter-clockwise outer contour

* cnct.cnt_f_z has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_n has a counter-clockwise outer contour

* cnct.cnt_o_z has a counter-clockwise outer contour

* 471 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Do outlines contain any jaggy segments? outline_jaggy_segments
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* A.cur (U+0041): L<<787.0,175.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.262109763757904

* A.cur.ini: L<<797.0,206.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.171345811249271

* r.mod.ini: L<<239.0,490.0>--<203.0,377.0>>/B<<203.0,377.0>-<228.0,418.0>-<253.0,445.5>> = 13.701954778116432

* r.mod.med: L<<265.0,490.0>--<228.0,377.0>>/B<<228.0,377.0>-<254.0,418.0>-<279.0,445.5>> = 14.250490794068266

[code: found-jaggy-segments]

⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? outline_semi_vertical
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* Wacute (U+1E82): L<<893.0,13.0>--<896.0,938.0>>

* Wacute (U+1E82): L<<948.0,1012.0>--<942.0,78.0>>

* Wcircumflex (U+0174): L<<893.0,13.0>--<896.0,938.0>>

* Wcircumflex (U+0174): L<<948.0,1012.0>--<942.0,78.0>>

* Wdieresis (U+1E84): L<<893.0,13.0>--<896.0,938.0>>

* Wdieresis (U+1E84): L<<948.0,1012.0>--<942.0,78.0>>

* Wgrave (U+1E80): L<<893.0,13.0>--<896.0,938.0>>

* Wgrave (U+1E80): L<<948.0,1012.0>--<942.0,78.0>>

* w.mod.fin: L<<104.0,11.0>--<102.0,489.0>>

* w.mod.ini: L<<104.0,11.0>--<102.0,489.0>>

* 6 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema googlefonts/vertical_metrics
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.977x (1977)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/playwritecoguides


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/playwritecoguides/PlaywriteCOGuides-Regular.ttf
Dehinted Size 349.1kb
Hinted Size 349.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.003']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 11 62 6 158 0
0% 0% 0% 5% 26% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal merged commit b5829ba into main Jan 10, 2025
8 checks passed
@emmamarichal emmamarichal deleted the PWG-PL-fixes branch January 10, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmamarichal emmamarichal emmamarichal approved these changes

Assignees
No one assigned
Labels
I Metadata/OFL
Projects
Fonts Traffic Jam
Status: In Dev / PR Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vv-monsalve @emmamarichal