New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tags.html: Implement Evan feedback #8176

Merged

emmamarichal merged 1 commit into main from tag-evan

Sep 18, 2024

Collaborator

m4rc1e commented Sep 17, 2024 •

edited

Loading

This PR implements feedback requested by Evan Adams:

Add a newline at the end of the csv
Add a comment mentioning that our sort function is case sensitive

I also removed some code duplication by refactoring it into a function.


          tags.html: Implement Evan feedback

171ec15

emmamarichal approved these changes

View reviewed changes

emmamarichal merged commit 312b4f3 into main

8 checks passed

emmamarichal deleted the tag-evan branch

September 18, 2024 08:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet