-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libre Franklin: Version 3.000 added #8134
Conversation
Taken from the upstream repo https://github.com/googlefonts/Libre-Franklin at commit googlefonts/Libre-Franklin@310b7ee.
This comment was marked as outdated.
This comment was marked as outdated.
💥 ERROR Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts. 🔥 FAIL Combined length of family and style must not exceed 32 characters. |
FontBakery reportfontbakery version: 0.12.10 Check results[20] LibreFranklin[wght].ttf💥 ERROR Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts.
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
4 | 0 | 1 | 16 | 77 | 21 | 365 | 0 |
1% | 0% | 0% | 3% | 16% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@felipesanches, if you have some time to take a look to these 2 ERRORS, it would be great! We can't merge the PR for now |
FontBakery reportfontbakery version: 0.12.10 Check results[20] LibreFranklin[wght].ttf💥 ERROR Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts.
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
4 | 0 | 1 | 16 | 77 | 21 | 365 | 0 |
1% | 0% | 0% | 3% | 16% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.12.10 Check results[20] LibreFranklin[wght].ttf💥 ERROR Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts.
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
4 | 0 | 1 | 16 | 77 | 21 | 365 | 0 |
1% | 0% | 0% | 3% | 16% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Taken from the upstream repo https://github.com/googlefonts/Libre-Franklin at commit googlefonts/Libre-Franklin@310b7ee.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectsprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.