-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edu AU VIC WA NT Pre: Version 1.001 added #8022
Conversation
FontBakery reportfontbakery version: 0.12.9 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] EduAUVICWANTPre[wght].ttfAll other checks[17] EduAUVICWANTPre[wght].ttf🔥 FAIL Shapes languages in all GF glyphsets.
|
ofl/eduauvicwantpre/EduAUVICWANTPre[wght].ttf | |
---|---|
Dehinted Size | 1.2Mb |
Hinted Size | 1.2Mb |
Increase | 24 bytes |
Change | 0.0 % |
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 7 | 44 | 11 | 189 | 0 |
0% | 0% | 0% | 3% | 17% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
PR name is wrong, but font name is correct. |
@EbenSorkin, have you seen this? :)
|
Maybe it's fixed now, let me take a look |
Is the CI still broken @simoncozens? The checks failed again 🤔 |
No, but rerunning the job runs it with the original Action, not the updated one. We need to add a new commit to start a new Action. |
1b13e15
to
87425fd
Compare
FontBakery reportfontbakery version: 0.12.10 Check results[18] EduAUVICWANTPre[wght].ttf🔥 FAIL Shapes languages in all GF glyphsets.
|
ofl/eduauvicwantpre/EduAUVICWANTPre[wght].ttf | |
---|---|
Dehinted Size | 1.2Mb |
Hinted Size | 1.2Mb |
Increase | 24 bytes |
Change | 0.0 % |
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 7 | 44 | 11 | 188 | 0 |
0% | 0% | 0% | 3% | 18% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontbakeryThis warns appeared in the last version:
I just check if it's intentional? Outlines / Anchors- Regarding quotes and #8022 (comment), is this result ok? - caron.alt position looks wrong |
87425fd
to
8f0e4df
Compare
I fixed the anchors on these glyphs. |
FontBakery reportfontbakery version: 0.13.0a1 Check results[18] EduAUVICWANTPre[wght].ttf
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: Ŀ, ŀ | ca_Latn (Catalan) |
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
Some auxiliary glyphs were missing: Ŧ, ŧ | nb_Latn (Norwegian Bokmål) |
⚠️ WARN Check font follows the Google Fonts vertical metric schema
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)
[code: bad-hhea-range]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/eduauvicwantpre/EduAUVICWANTPre[wght].ttf | |
---|---|
Dehinted Size | 1.2Mb |
Hinted Size | 1.2Mb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
- vhea
- vmtx
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/SorkinType/VICWANTSchoolhandAustralia
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 0 | 8 | 45 | 11 | 189 | 0 |
0% | 0% | 0% | 3% | 18% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
PR Checklist:
- [ ] Minisite_url definition in the METADATA.pb file for commissioned projects- [ ] Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target