Introduce new streaming RPCs to the admin server. #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new RPCs are: - `StreamClientIds` - `StreamClientContacts` The motivation is that both the client and client contacts tables can be very large.
bgalehouse
reviewed
Apr 22, 2021
| @@ -51,6 +51,32 @@ func uint64ToBytes(i uint64) []byte { | |||
| return b | |||
| } | |||
|
|
|||
| func (d *Datastore) StreamClientIds(ctx context.Context, callback func(common.ClientID) error) error { | |||
| return d.runInTx(ctx, true, func(tx *sql.Tx) error { | |||
There was a problem hiding this comment.
runInTx is a retry loop, which could lead to strange behavior (duplicate events, mostly). Maybe streaming reads should just call "runOnce" directly, and recognize that the caller might need to retry?
Also, it might be a time to fix (well, implement) the handling of the readonly flag. At least, recent versions of the golang sql package provide a way to pass it in to BeginTx. I don't know how complete the actual mysql driver support is.
There was a problem hiding this comment.
Done switching to runOnce.
I've created #321 for the readonly flag.
bgalehouse
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new RPCs are:
StreamClientIdsStreamClientContactsThe motivation is that both the client and client contacts tables can be very
large.