Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins to components #179

Merged
merged 5 commits into from
Apr 2, 2019
Merged

Plugins to components #179

merged 5 commits into from
Apr 2, 2019

Conversation

bgalehouse
Copy link
Contributor

Convert component configuration model to something simpler. Remove plugins support - users requiring code additions should recompile everything.

#169

@bgalehouse bgalehouse requested a review from ogarod April 2, 2019 10:22
ogarod
ogarod approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@ogarod ogarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan on adding tests for new functionality in a future PR?

@bgalehouse
Copy link
Contributor Author

PTAL, added a partial test and a few high-level comments.

@ogarod ogarod merged commit 3e7d892 into google:master Apr 2, 2019
@bgalehouse bgalehouse deleted the plugins-components branch April 3, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogarod ogarod ogarod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgalehouse @ogarod