Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoRALinearGeneral
sinceMultiHeadAttention
usesLinearGeneral
.axis
inLinearGeneral.__init__()
so that it is compatible to in_features that is a suquence of intslora_base_module
param toLoRALinear
so that it's consistent withLoRA
Since
LoRA
currently doesn't support dot_general, I reshape the input before and after calling lora. I also add a check on the value ofaxis
param inLinearGeneral
, so that it's only valid to apply linear transformation on the last axes of the input.I got trouble running the tests, so I couldn't add one.