Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: grpc python code generation location and file suffix #8359

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bugfix: grpc python code generation location and file suffix #8359

wants to merge 4 commits into from

Commits on Jul 11, 2024

  1. clang-format

    @fliiiix
    fliiiix committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7eb9c3a View commit details
    Browse the repository at this point in the history

  2. [Python] Replace . with _ in grpc filename suffix 

    Having filenames with . like `file.fb.grcp`
is not great for Python. Since dots are used for namespaces.
Replacing all of them with _ eg suffix `foo.bar.baz` will become
`foo_bar_baz`.

Restoring the previous default `_fb` suffix.
    @fliiiix
    fliiiix committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b88b558 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. [Python] Use namespace in path 

    This fixes a regression introduced with:
fb9afba
And generates the grpc file in the namespace folder again.
    @fliiiix
    fliiiix committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ce2f58a View commit details
    Browse the repository at this point in the history

  2. Sync commandline docs with web docs

    @fliiiix
    fliiiix committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    95c0ab2 View commit details
    Browse the repository at this point in the history