Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Updates CocoaPods author info & fixes bug with versioning not working as expected #8328

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

mustiikhalil
Copy link
Collaborator

The following PR fixes the author CocoaPods information and fixes a bug where the branch tag wasn't parsed properly due to the tags not having vX.Y.Z instead of X.Y.Z

@mustiikhalil
Copy link
Collaborator Author

@dbaileychess can I get a review for this PR

@mustiikhalil mustiikhalil merged commit 6a88985 into google:master Oct 4, 2024
48 checks passed
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
… working as expected (google#8328)

* Fix versioning not being able to parse vX.Y.Z and updates author

* Adds BUILD_LIBRARY_FOR_DISTRIBUTION flag for cocoapods
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
… working as expected (google#8328)

* Fix versioning not being able to parse vX.Y.Z and updates author

* Adds BUILD_LIBRARY_FOR_DISTRIBUTION flag for cocoapods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants