Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MODULE.bazel and avoid directly running npm commands. #8305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jjh42
Copy link

@jjh42 jjh42 commented May 12, 2024

I'm not sure if you directly able to accept this PR if people are relying on the workspace rule but this can at least start a discussion.

This patches flatbuffers for use with bazel modules.
Its based on:
https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/flatbuffers
but removes the npm commands since they conflict with a repo that already uses npm.

Copy link

google-cla bot commented May 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jkuszmaul
Copy link
Contributor

Getting flatbuffers onto bzlmod would be great; see some prior effort at #8227 and issue reference at #7695. I'd guess no one took the time to review #8227 since I don't see any reason it shouldn't've gotten reviewed.

@github-actions github-actions bot added c++ codegen Involving generating code from schema grpc labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema grpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants