Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] add ResetKeep() and ResetBuffer() #8288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdemeyer
Copy link
Contributor

Add a function ResetKeep() which is like Reset() except that it only re-uses the unused space left in the buffer: it keeps previous data which was in the buffer. This is useful if you want to allocate 1 large buffer and use it for a bunch of flatbuffer objects.

With this change, both Reset() and ResetKeep() are now implemented in terms of a general ResetBuffer() function which allows using an arbitrary given buffer.

This also changes the behaviour of growBytesBuffer to never re-use the existing buffer: that would go against the meaning of ResetKeep(). It was an unlikely code path anyway: it could happen only if len(b.Bytes) < cap(b.Bytes) which is only possible if the user manually set b.Bytes.

The code in growBytesBuffer was also simplified and optimized: the benchmark added in #8287 went from

BenchmarkBuildAllocations-12             2186073              1595 ns/op          81.49 MB/s         824 B/op         13 allocs/op

to

BenchmarkBuildAllocations-12             2396973              1432 ns/op          90.79 MB/s         560 B/op          6 allocs/op

on my personal laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant