-
Notifications
You must be signed in to change notification settings - Fork 3.3k
rust: Allow for usage of flatbuffers in #![no_std] environment #6989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@CasperN Could you check this? This was an internal request. |
LGTM, sorry for the delayed review. Please pull from master, sign the CLA, and I'll merge when tests pass. |
Rebased and CLA sorted out. |
Sorry @MarWit, one more thing, can you bump the minor version number in the Looks like the CI failure has to do with Java and Android, so it seem irrelevant to this PR. |
Done. Just a little reminder that this change is using our forks of |
|
Rust CI failed with 403, which is ...interesting I think its fine to merge since the only change from the force push should've been the version number and cargo.toml. @MarWit are you good to merge? |
Yes. There is still |
I'll publish to crates.io once that is upstreamed and updated in our Cargo.toml (they require dependencies to have published versions to publish). |
@MarWit when do you expect the upstreaming to happen? |
I am currently waiting for the feedback from the crate's maintainer, so I sadly do not have any ETA right now. I will let you know when I will have any information. |
Gotcha, note that while we do not publish often, this is blocking publishing; so I'd prefer it gets resolved within a couple weeks - lest we risk slowing down another contributor. I hope that's plenty of time, but let me know if upstreaming gets blocked and we can figure something out. |
Hey,
this PR introduces changes that allow for usage of flatbuffers in
#![no_std]
environments. The main difference to this PR is that instead of removingthiserror
forno_std
builds it usescore2
andthiserror_core2
in its place. Thecore2
crate needed some small changes, so I had to use fork for the time being.