Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TSAN violation in HandleAllocator #8438

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix TSAN violation in HandleAllocator #8438

merged 1 commit into from
Feb 13, 2025

Conversation

bejado
Copy link
Member

@bejado bejado commented Feb 11, 2025

BUGS = [378375177]

@bejado bejado added the internal Issue/PR does not affect clients label Feb 11, 2025
pixelflinger
pixelflinger requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@pixelflinger pixelflinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to fix this using mLock instead of making it an atomic. Actually I changed my mind. It's fine.

@pixelflinger pixelflinger merged commit 18529fa into main Feb 13, 2025
14 checks passed
@pixelflinger pixelflinger deleted the bjd/tsan-handleallocator branch February 13, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflinger pixelflinger pixelflinger approved these changes

@z3moon z3moon Awaiting requested review from z3moon

@poweifeng poweifeng Awaiting requested review from poweifeng

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bejado @pixelflinger